Add docs and rest api spec for saml complete logout API #72867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ywangd
added
>docs
|
Pinging @elastic/clients-team (Team:Clients) |
|
Pinging @elastic/es-security (Team:Security) |
|
Pinging @elastic/es-docs (Team:Docs) |
ywangd
commented
May 10, 2021
| (Required, array) A json array with all the valid SAML Request Ids that the caller of | ||
| the API has for the current user. | ||
|
|
||
| `queryString`:: |
There was a problem hiding this comment.
I think our APIs generally prefer snake case. So this should have been query_string instead of queryString. This is unfortunately another oversight of the original PR #56316. I can deprecate it and add a new query_string field in another follow-up PR.
There was a problem hiding this comment.
Yeah, maybe raise an issue for it.
| "stability":"stable", | ||
| "visibility":"public", | ||
| "headers":{ | ||
| "accept": [ "application/json"] |
There was a problem hiding this comment.
I'm not sure if this is used:
"content_type": ["application/json"]
There was a problem hiding this comment.
Thanks for catching this. I think it should be included.
ywangd
added a commit
to ywangd/elasticsearch
that referenced
this pull request
May 31, 2021
This PR adds the documentation and Rest API spec file for the SAML complete logout API. It is a (overdued) follow up for elastic#56316
ywangd
added a commit
that referenced
this pull request
May 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the documentation and Rest API spec file for the SAML complete logout API.
It is a (overdued) follow up for #56316
Doc preview URL: https://elasticsearch_72867.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/security-api-saml-complete-logout.html
Relates: #67189, #72839