Fix Watcher HTTP connection config for longevity #72736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Watcher uses a connection pool for outgoing HTTP traffic, which means that some HTTP connections may live for a long time, possibly in an idle state. Such connections may be silently torn down by a remote device, so that when we re-use them we encounter a `Connection reset` or similar error. This commit introduces a setting allowing users to set a finite expiry time on these connections, and also enables TCP keepalives on them by default so that a remote teardown will be actively detected sooner. Closes elastic#52997
|
Pinging @elastic/es-core-features (Team:Core/Features) |
DaveCTurner
commented
May 5, 2021
| @@ -770,6 +770,50 @@ public void testCreateUri() throws Exception { | |||
| assertCreateUri("https://example.org", ""); | |||
| } | |||
|
|
|||
| public void testConnectionReuse() throws Exception { | |||
There was a problem hiding this comment.
This was the least flaky way I could think of to test this but it's not exactly watertight, we cannot 100% guarantee that the connection will be re-used in the first case, nor can we guarantee that the client port won't be re-used in the second case.
I also couldn't work out a way to test that TCP keepalives are enabled at all.
|
@elasticmachine please run elasticsearch-ci/2 |
|
@elasticmachine update branch |
jakelandis
approved these changes
May 5, 2021
There was a problem hiding this comment.
Thanks David, these changes look good and is much better then current workaround of sending a connection closed header to force non-persistent connections.
DaveCTurner
added a commit
that referenced
this pull request
May 6, 2021
Watcher uses a connection pool for outgoing HTTP traffic, which means that some HTTP connections may live for a long time, possibly in an idle state. Such connections may be silently torn down by a remote device, so that when we re-use them we encounter a `Connection reset` or similar error. This commit introduces a setting allowing users to set a finite expiry time on these connections, and also enables TCP keepalives on them by default so that a remote teardown will be actively detected sooner. Closes #52997
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Watcher uses a connection pool for outgoing HTTP traffic, which means
that some HTTP connections may live for a long time, possibly in an idle
state. Such connections may be silently torn down by a remote device, so
that when we re-use them we encounter a
Connection resetor similarerror.
This commit introduces a setting allowing users to set a finite expiry
time on these connections, and also enables TCP keepalives on them by
default so that a remote teardown will be actively detected sooner.
Closes #52997