Fix SearchableSnapshotsLicenseIntegTests.testShardAllocationOnInvalidLicense #72528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlrx
added
>test
elasticmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
original-brownbear
approved these changes
Apr 30, 2021
| @@ -89,6 +89,9 @@ public void createAndMountSearchableSnapshot() throws Exception { | |||
|
|
|||
| assertAcked(client().execute(DeleteLicenseAction.INSTANCE, new DeleteLicenseRequest()).get()); | |||
| assertAcked(client().execute(PostStartBasicAction.INSTANCE, new PostStartBasicRequest()).get()); | |||
|
|
|||
| ensureClusterSizeConsistency(); | |||
There was a problem hiding this comment.
NIT: I think we can do it in one line with ensureStableCluster(cluster().size())? That seems like it's all we need here? Looks like this is a retry on the master node request I guess? (though there's no master fail-over, but maybe a connection got dropped for some reason?) ... That's my best guess :)
There was a problem hiding this comment.
I merged as is, I wanted to ensure no pending tasks on all nodes with the same cluster state everywhere.
And yes, retries might explain this. We'll see if that happens again
|
Thanks Armin |
tlrx
added a commit
to tlrx/elasticsearch
that referenced
this pull request
May 3, 2021
…License (elastic#72528) This test fails sometimes on CI (see elastic#72329) when recreating the license. It's not clear to me why that happens but I suspect batched cluster state updates, so this pull request adds some waiting points in the test. Closes elastic#72329
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test fails sometimes on CI (see #72329) when recreating the license. It's not clear to me why that happens but I suspect batched cluster state updates, so this pull request adds some waiting points in the test.
Closes #72329