Increase implicit suite timeout to 40 mins #72495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertzaharovits
added
>test
|
Pinging @elastic/es-delivery (Team:Delivery) |
albertzaharovits
added a commit
that referenced
this pull request
Apr 29, 2021
The MixedClusterClientYamlTestSuiteIT test suite has been ordained with a 40 mins timeout. But the ElasticsearchTestBasePlugin overrides the suite annotation, using a system prop, to 30 mins; see also SysGlobals#SYSPROP_TIMEOUT_SUITE . This PR increases the value for the system prop override to 40 mins, to match the above suites declarations. Closes #72393
albertzaharovits
added a commit
that referenced
this pull request
Apr 29, 2021
The MixedClusterClientYamlTestSuiteIT test suite has been ordained with a 40 mins timeout. But the ElasticsearchTestBasePlugin overrides the suite annotation, using a system prop, to 30 mins; see also SysGlobals#SYSPROP_TIMEOUT_SUITE . This PR increases the value for the system prop override to 40 mins, to match the above suites declarations. Closes #72393
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
MixedClusterClientYamlTestSuiteITtest suite has been ordained with a 40 mins timeout .But the
ElasticsearchTestBasePluginoverrides the suite annotation, using a system prop, to 30 mins; see also SysGlobals#SYSPROP_TIMEOUT_SUITE .This has recently caused a timeout fest on windows machines:
https://gradle-enterprise.elastic.co/s/3tftym4uu3s66
https://gradle-enterprise.elastic.co/s/ufgbyhkw3hgsi
https://gradle-enterprise.elastic.co/s/uiox4z3ft7qcm
https://gradle-enterprise.elastic.co/s/3ac6u6iojr67m
This PR increases the value for the system prop override to 40 mins (to match the above suites declarations)
Closes #72393