Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make feature reset API response more informative (#71240) #72341

Merged

Conversation

williamrandolph
Copy link
Contributor

Previously, the ResetFeatureStateStatus object captured its status in a
String, which meant that if we wanted to know if something succeeded or
failed, we'd have to parse information out of the string. This isn't a
good way of doing things.

I've introduced a SUCCESS/FAILURE enum for status constants, and added a
check for failures in the transport action. We return a 207 if some but not all
reset actions fail, and for every failure, we also return information about the
exception or error that caused it.

williamrandolph and others added 2 commits April 27, 2021 17:52
* Add docs for feature reset API
* Prose and style much improved by Deb Adair.

Co-authored-by: debadair <[email protected]>
…stic#72332)

* Make feature reset API response more informative (elastic#71240)

Previously, the ResetFeatureStateStatus object captured its status in a
String, which meant that if we wanted to know if something succeeded or
failed, we'd have to parse information out of the string. This isn't a
good way of doing things.

I've introduced a SUCCESS/FAILURE enum for status constants, and added a
check for failures in the transport action. We return a 207 if some but not all
reset actions fail, and for every failure, we also return information about the
exception or error that caused it.

* Fix 7.x backport compilation issues

* Feature reset integration test should tolerate failed resets (elastic#72326)

Co-authored-by: Jay Modi <[email protected]>
@williamrandolph williamrandolph merged commit 3db1394 into elastic:7.13 Apr 28, 2021
@williamrandolph williamrandolph deleted the backport/7.13/reset-api-fail-fast branch May 23, 2022 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant