[Rest Api Compatibility] Typed endpoints for search and related endpoints #72155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgomulka
changed the title
pgomulka
added
:Core/Infra/REST API
elasticmachine
added
Team:Core/Infra
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
|
Pinging @elastic/es-search (Team:Search) |
romseygeek
approved these changes
May 11, 2021
| @@ -120,6 +129,12 @@ public static void parseSearchRequest(SearchRequest searchRequest, RestRequest r | |||
| XContentParser requestContentParser, | |||
| NamedWriteableRegistry namedWriteableRegistry, | |||
| IntConsumer setSize) throws IOException { | |||
| if (request.getRestApiVersion() == RestApiVersion.V_7 && | |||
| (request.hasParam(INCLUDE_TYPE_NAME_PARAMETER) || request.hasParam("type"))) { | |||
There was a problem hiding this comment.
Does include_type_name actually have an effect here?
There was a problem hiding this comment.
good point, it is not needed. I mistakenly assumed that it is needed as other APIs so far were expecting it.
I removed it
| //possibly this needs a separate issue to track the problem | ||
| // if we emit a compatible warning when a type parameter (?type=some_type) is present, | ||
| // then for APIs where a {type} is used a compatible warning would be emitted twice | ||
| // this is because we cannot distinguish between them and for {type} we already emit a warning when using a Route |
There was a problem hiding this comment.
I think this is fine? If you specify the type in two places you get two warnings.
There was a problem hiding this comment.
I probably did not made this clear. The problem is that you would get two warnings when specifying the type in {type} as in path.
The problem only occurs when an expected paramter ?type has the same name as the parameter in braces {type}
66 tasks
pgomulka
added a commit
to pgomulka/elasticsearch
that referenced
this pull request
May 14, 2021
enabeling the tests and adds a type field for termvector response the commit that enabled typed enpoints but missed to update the response elastic#72155
pgomulka
added a commit
that referenced
this pull request
May 19, 2021
Enabling the tests and adds a type field for termvector response the commit that enabled typed endpoints but missed to update the response #72155
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a V7 compatible typed endpoints for REST for search related apis
retrofits the REST layer change removed in #41640
relates main meta issue #51816
relates types removal issue #54160