Added transient header support for TransportMessage #7187
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
uboness
commented
Aug 7, 2014
uboness
commented
- Transient headers are headers that can be set on messages yet are not serialized with them.
- Changed header accessors/mutators so header manipulation will be done directly on the request (to void NPE with transport message headers when dealing with maps that can potentially be null)
- Added a randomVersionCompatibleWith(Version) method to the test infrastructure to help with bwc testing
|
I think it's ok to add the ability to add some context to messages, that can be reused during processing, but I don't think we should reuse headers for that, this should be a separate data-structure. |
|
@jpountz fair enough... we can have another construct in the request, say... |
|
|
||
| /** | ||
| * | ||
| */ | ||
| public abstract class TransportMessage<TM extends TransportMessage<TM>> implements Streamable { | ||
|
|
||
| // a transient (not serialized with the request) key/value registry | ||
| private final Map<String, Object> context = new HashMap<>(); |
There was a problem hiding this comment.
I think it would be more flexible if the keys were objects? (you could have composite keys, etc.)
There was a problem hiding this comment.
yeah... I guess (will change it)
There was a problem hiding this comment.
Other question: does it need to be a concurrent map?
|
@uboness Left some comments |
|
@jpountz final pass? |
| } | ||
| this.context = new HashMap<>(((TransportMessage<?>) message).context); |
There was a problem hiding this comment.
hmm do we really want to copy the context?
There was a problem hiding this comment.
yea... I think we do... it's data that is associated with the request (like the headers)
- The context enables setting arbitrary transient data on the message (this data is not serialized with the request) - Changed header accessors/mutators so header manipulation will be done directly on the request (to void NPE with transport message headers when dealing with maps that can potentially be null)
|
merged with 1f9bceb |
clintongormley
changed the title
clintongormley
changed the title
dnhatn
added a commit
that referenced
this pull request
Jul 7, 2020
If the recovery source is on an old node (before 7.2), then the recovery target won't have the safe commit after phase1 because the recovery source does not send the global checkpoint in the clean_files step. And if the recovery fails and retries, then the recovery stage won't transition properly. If a sync_id is used in peer recovery, then the clean_files step won't be executed to move the stage to TRANSLOG. Relates ##7187 Closes #57708
dnhatn
added a commit
that referenced
this pull request
Jul 7, 2020
If the recovery source is on an old node (before 7.2), then the recovery target won't have the safe commit after phase1 because the recovery source does not send the global checkpoint in the clean_files step. And if the recovery fails and retries, then the recovery stage won't transition properly. If a sync_id is used in peer recovery, then the clean_files step won't be executed to move the stage to TRANSLOG. Relates ##7187 Closes #57708
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.