Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Alters examples in anomaly detection page to use runtime mappings #71745

Merged
merged 4 commits into from
Apr 19, 2021
Merged

[DOCS] Alters examples in anomaly detection page to use runtime mappings #71745

merged 4 commits into from
Apr 19, 2021

Conversation

szabosteve
Copy link
Contributor

@szabosteve szabosteve commented Apr 15, 2021 •
edited
Loading

Overview

This PR:

  • changes the examples in ml-configuring-transform.asciidoc to use runtime_mappings instead of script_fields
  • changes the title of the page from Transforming data with script fields to Altering data with runtime mappings (transforming is misleading as the page is not about transforms),
  • revises the text on the page and amend the content to be in line with the new examples (change script fields terminology to runtime fields),
  • changes a screenshot,
  • changes the order and the number of the last two examples on the page (Example 8 and 9),
  • comments out the last example (now Example 9, formerly Example 8) and the link to it on the top of the page.

Related issue: #69291

Preview

This page is rendered in the ML book. For this reason, there is no automatically generated preview for the changes.

@szabosteve szabosteve added :ml Machine learning >docs General docs changes v7.13.0 v8.0.0 labels Apr 15, 2021
@szabosteve szabosteve requested a review from davidkyle April 15, 2021 14:13
@szabosteve szabosteve marked this pull request as ready for review April 15, 2021 14:13
@elasticmachine elasticmachine added Team:ML Meta label for the ML team Team:Docs Meta label for docs team labels Apr 15, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@szabosteve szabosteve requested a review from lcawl April 15, 2021 14:14
davidkyle
davidkyle approved these changes Apr 15, 2021
View reviewed changes
Copy link
Member

@davidkyle davidkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code samples LGTM

@szabosteve szabosteve mentioned this pull request Apr 19, 2021
Open
@szabosteve szabosteve merged commit aca0a7f into elastic:master Apr 19, 2021
@szabosteve szabosteve deleted the script.runtime.examples branch April 19, 2021 11:06
szabosteve added a commit to szabosteve/elasticsearch that referenced this pull request Apr 19, 2021
@szabosteve
[DOCS] Alters examples in anomaly detection page to use runtime mappi…
26dca8b 
…ngs (elastic#71745)
@szabosteve szabosteve mentioned this pull request Apr 19, 2021
Merged
szabosteve added a commit that referenced this pull request Apr 19, 2021
@szabosteve
[DOCS] Alters examples in anomaly detection page to use runtime mappi…
36440f1 
…ngs (#71745) (#71821)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcawl lcawl lcawl left review comments

@davidkyle davidkyle davidkyle approved these changes

Assignees
No one assigned
Labels
>docs General docs changes :ml Machine learning Team:Docs Meta label for docs team Team:ML Meta label for the ML team v7.13.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@szabosteve @elasticmachine @davidkyle @lcawl @jakelandis