Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add index-time scripts to date field mapper #71633

Merged
merged 3 commits into from
Apr 14, 2021
Merged

Add index-time scripts to date field mapper #71633

merged 3 commits into from
Apr 14, 2021

Conversation

romseygeek
Copy link
Contributor

This commit allows you to set 'script' and 'on_script_error' parameters
on date field mappers, meaning that runtime date fields can be made indexed
simply by moving their definitions from the runtime section of the mappings
to the properties section.

@romseygeek romseygeek added >feature :Search Foundations/Mapping Index mappings, including merging and defining field types v8.0.0 v7.13.0 labels Apr 13, 2021
@romseygeek romseygeek requested a review from javanna April 13, 2021 13:15
@romseygeek romseygeek self-assigned this Apr 13, 2021
@elasticmachine elasticmachine added the Team:Search Meta label for search team label Apr 13, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

javanna
javanna approved these changes Apr 13, 2021
View reviewed changes
Copy link
Member

@javanna javanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romseygeek
Copy link
Contributor Author

@elasticmachine update branch

@romseygeek
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/eql-correctness

javanna
javanna approved these changes Apr 14, 2021
View reviewed changes
Copy link
Member

@javanna javanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romseygeek romseygeek merged commit 05551dd into elastic:master Apr 14, 2021
@romseygeek romseygeek deleted the mapper/date-index-scripts branch April 14, 2021 08:18
romseygeek added a commit that referenced this pull request Apr 14, 2021
@romseygeek
Add index-time scripts to date field mapper (#71633)
34b13c2 
This commit allows you to set 'script' and 'on_script_error' parameters
on date field mappers, meaning that runtime date fields can be made indexed
simply by moving their definitions from the runtime section of the mappings
to the properties section.
@javanna javanna mentioned this pull request Apr 19, 2021
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javanna javanna javanna approved these changes

Assignees

@romseygeek romseygeek

Labels
>feature :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Search Meta label for search team v7.13.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@romseygeek @elasticmachine @javanna @jakelandis