Cleanup SnapshotsInProgress for Readability #71620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*Formatting `SnapshotsInProgress` in a more reasonable way instead of mixing nested class, fields and methods. * Removing pointless constants for the x-content serialization. * Cleaning up double wrapping in `unmodifiableList`. * Removing unused and incorrectly documented constructor from `SnapshotDeletionsInProgress`
original-brownbear
added
>non-issue
:Distributed Coordination/Snapshot/Restore
elasticmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
DaveCTurner
approved these changes
Apr 13, 2021
server/src/main/java/org/elasticsearch/cluster/SnapshotsInProgress.java
Outdated
Show resolved
Hide resolved
|
Thanks David! |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Apr 19, 2021
* Formatting `SnapshotsInProgress` in a more reasonable way instead of mixing nested class, fields and methods. * Removing pointless constants for the x-content serialization. * Cleaning up double wrapping in `unmodifiableList`. * Removing unused and incorrectly documented constructor from `SnapshotDeletionsInProgress`
original-brownbear
added a commit
that referenced
this pull request
Apr 19, 2021
* Formatting `SnapshotsInProgress` in a more reasonable way instead of mixing nested class, fields and methods. * Removing pointless constants for the x-content serialization. * Cleaning up double wrapping in `unmodifiableList`. * Removing unused and incorrectly documented constructor from `SnapshotDeletionsInProgress`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SnapshotsInProgressin a more reasonable way instead of mixing nested class, fields and methods.unmodifiableList.SnapshotDeletionsInProgressno functional changes otherwise.