Add index-time scripts to IP field mapper #71617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romseygeek
added
>feature
:Search Foundations/Mapping
|
Pinging @elastic/es-search (Team:Search) |
romseygeek
commented
Apr 13, 2021
| public final void runForDoc(int docId, Consumer<InetAddress> consumer) { | ||
| runForDoc(docId); | ||
| for (int i = 0; i < count; i++) { | ||
| consumer.accept(InetAddressPoint.decode(values[i].bytes)); |
There was a problem hiding this comment.
Annoyingly, emit takes an InetAddress and encodes it into a BytesRef and this then immediately decodes it back to an InetAddress to pass to the indexer. Possibly as a follow up it might be worth changing the script to store its values as InetAddresses and to decode them for doc values access only?
javanna
approved these changes
Apr 13, 2021
| public final void runForDoc(int docId, Consumer<InetAddress> consumer) { | ||
| runForDoc(docId); | ||
| for (int i = 0; i < count; i++) { | ||
| consumer.accept(InetAddressPoint.decode(values[i].bytes)); |
| * @param context the search execution context | ||
| * @return the value fetcher | ||
| */ | ||
| static ValueFetcher valueFetcher(FieldValues<?> fieldValues, Function<Object, Object> formatter, SearchExecutionContext context) { |
There was a problem hiding this comment.
the plan is to reuse this for dates too?
romseygeek
added a commit
that referenced
this pull request
Apr 13, 2021
This commit allows you to set 'script' and 'on_script_error' parameters on IP field mappers, meaning that runtime IP fields can be made indexed simply by moving their definitions from the runtime section of the mappings to the properties section.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows you to set 'script' and 'on_script_error' parameters
on IP field mappers, meaning that runtime IP fields can be made indexed
simply by moving their definitions from the runtime section of the mappings
to the properties section.