Add scripts to keyword field mapper #71555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romseygeek
added
>feature
:Search Foundations/Mapping
|
Pinging @elastic/es-search (Team:Search) |
javanna
approved these changes
Apr 12, 2021
| super(name); | ||
| this.indexAnalyzers = indexAnalyzers; | ||
| this.scriptCompiler = scriptCompiler; | ||
| this.script.precludesParameters(nullValue); |
There was a problem hiding this comment.
how about ignore_above and normalizer? Should they be supported when a script is set?
There was a problem hiding this comment.
Yes, I've included those - they're both things that are applied after a value has been read, as opposed to null_value which is applied instead of a value.
| } | ||
|
|
||
| public Builder(String name) { | ||
| this(name, null); | ||
| this(name, null, null); |
There was a problem hiding this comment.
ehm, I think you'll have to use ScriptCompiler.NONE here
romseygeek
added a commit
that referenced
this pull request
Apr 12, 2021
This commit adds script and on_script_error parameters to keyword field mappers, allowing you to define index-time scripts for keyword fields.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds
scriptandon_script_errorparameters tokeyword field mappers, allowing you to define index-time scripts
for keyword fields.