Support fetching _tier field value #71379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtibshirani
added
>enhancement
:Search/Search
|
Pinging @elastic/es-search (Team:Search) |
zkscpqm
reviewed
Apr 7, 2021
...main/java/org/elasticsearch/xpack/cluster/routing/allocation/mapper/DataTierFieldMapper.java
Outdated
Show resolved
Hide resolved
jtibshirani
commented
Apr 7, 2021
| } | ||
|
|
||
| String tierPreference = getTierPreference(context); | ||
| return lookup -> singletonList(tierPreference); |
There was a problem hiding this comment.
I just noticed this doesn't handle a missing/ empty setting correctly. I'll push a fix.
Update: while writing tests I noticed we don't handle this correctly and opened #71439. I'll return to this PR once that is merged.
|
This looks good to me, I'll take another look after #71439 is merged but I assume this PR doesn't change much with it. |
cbuescher
approved these changes
Apr 8, 2021
cbuescher
reviewed
Apr 8, 2021
| Settings settings = context.getIndexSettings().getSettings(); | ||
| String value = DataTierAllocationDecider.INDEX_ROUTING_PREFER_SETTING.get(settings); | ||
|
|
||
| if (value == null) { |
There was a problem hiding this comment.
I assume this will change after #71439 is in, so keeping this comment here for now just to recheck
|
@cbuescher thanks for reviewing, it's ready for another look. |
|
Thanks for the ping, nothing to add from my side, so LGTM (pending CI which looks almost done) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the
fieldsoption allows fetching metadata fields, we can supportloading the new
_tiermetadata field.Relates to #63569 and #68135.