QL: Improve removal of items during iteration #71193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clean-up the range optimization rule by avoid the use of indices during iteration and removal (since it skips an element each time) Remove redundant ternary calls
costin
added
>enhancement
:Analytics/SQL
|
Pinging @elastic/es-ql (Team:QL) |
bpintea
approved these changes
Apr 2, 2021
|
I think the issue did not occur in practice since the rule skipped one element but on a subsequent run, it picked it up and applied the compression again. |
costin
added a commit
to costin/elasticsearch
that referenced
this pull request
Apr 3, 2021
Clean-up the range optimization rule by avoid the use of indices during iteration and removal (since it skips an element each time) Remove redundant ternary calls
costin
added a commit
to costin/elasticsearch
that referenced
this pull request
Apr 3, 2021
Clean-up the range optimization rule by avoid the use of indices during iteration and removal (since it skips an element each time) Remove redundant ternary calls
costin
added a commit
that referenced
this pull request
Apr 3, 2021
costin
added a commit
that referenced
this pull request
Apr 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean-up the range optimization rule by avoid the use of indices during
iteration and removal (since it skips an element each time)
Remove redundant ternary calls