[ML] fix test failure from issue #71150 #71176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benwtrent
added
>test
elasticmachine
added
Team:ML
|
Pinging @elastic/ml-core (Team:ML) |
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
|
Is this implying that the new feature reset API requires Given the conversations we've had recently about not using this API in production I can see some sense in that, but it needs to be clearly documented and the feature reset API should fail fast without doing a partial reset if the flag is incorrectly set. But if we see the future direction of Either way, this PR could be merged as-is as an interim solution. |
|
@droberts195 I opened: #71178 |
droberts195
approved these changes
Apr 1, 2021
There was a problem hiding this comment.
I opened: #71178
Thanks. I am happy to merge this as an interim fix while that is discussed.
droberts195
added a commit
to droberts195/elasticsearch
that referenced
this pull request
Jun 3, 2021
After elastic#71150 was merged we had to allow wildcarded deletions in our native multi-node tests, because the feature reset API was doing a wildcarded deletion. This is not ideal because we then might rely on wildcarded deletion somewhere else and not notice in our tests. Now that elastic#73017 is merged we should no longer need to allow wildcarded deletion for the benefit of the feature reset API. Therefore, this PR reverts the setting change that was made in elastic#71176. Over time our testing will then validate that the feature reset API really does work with wildcarded deletes disallowed.
droberts195
added a commit
that referenced
this pull request
Jun 4, 2021
After #71150 was merged we had to allow wildcarded deletions in our native multi-node tests, because the feature reset API was doing a wildcarded deletion. This is not ideal because we then might rely on wildcarded deletion somewhere else and not notice in our tests. Now that #73017 is merged we should no longer need to allow wildcarded deletion for the benefit of the feature reset API. Therefore, this PR reverts the setting change that was made in #71176. Over time our testing will then validate that the feature reset API really does work with wildcarded deletes disallowed.
droberts195
added a commit
that referenced
this pull request
Jun 4, 2021
After #71150 was merged we had to allow wildcarded deletions in our native multi-node tests, because the feature reset API was doing a wildcarded deletion. This is not ideal because we then might rely on wildcarded deletion somewhere else and not notice in our tests. Now that #73017 is merged we should no longer need to allow wildcarded deletion for the benefit of the feature reset API. Therefore, this PR reverts the setting change that was made in #71176. Over time our testing will then validate that the feature reset API really does work with wildcarded deletes disallowed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently merged was a change that modified the default value of:
action.destructive_requires_nametotrue.The original merge was fairly careful to adjust all the test clusters to account for the default value change.
However, the machine learning test runner was missed. We create custom node settings and thus require
the handling of the default value change.
relates to #71150