Rename ql:test project to ql:test-fixtures to avoid IntelliJ confusion #71135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-delivery (Team:Delivery) |
pugnascotia
approved these changes
Mar 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IntelliJ is setup such that it creates a module per Gradle project source set. This means most Gradle projects actually map to multiple IntelliJ modules. In the most common scenario you get a
mainandtestmodule. These "submodule" names are generated by appending the source set name to the project name. So:servercreates two modules,server.mainandserver.test.The
:x-pack:plugin:qlproject was unique in that it had both a source set namedtestas well as a subproject namedtest. This means that IntelliJ had two modules, both with the namex-pack.plugin.ql.testwhich could occasionally cause sync issues or the IDE to report it couldn't find classes.The solution here was simply to rename the
ql:testproject to something unique, in this case,test-fixtureswhich is actually a better description of what that project actually is anyhow.