Wait for rollover to happen in testShrinkActionInPolicyWithoutHotPhase #70658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also removes testShrinkAfterRollover because it was passing for the wrong reasons (the srhunk index name it was composing never existed anymore) and the scenario is already extensively tested in `ShrinkActionIT`, without using a full policy that is subject to flakiness as the managed index might get deleted before we pick up the shrink index name from the execution state.
andreidan
added
>test
elasticmachine
added
the
Team:Data Management
|
Pinging @elastic/es-core-features (Team:Core/Features) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an extra step in
testShrinkActionInPolicyWithoutHotPhaseto wait for therollover to happen before trying to read the shrink index name from the execution
state.
This also removes
testShrinkAfterRolloverbecause it was passing for thewrong reasons (the shrunk index name it was composing never existed
anymore) and the scenario is already extensively tested in
ShrinkActionIT, without using a full policy that is subject toflakiness as the managed index might get deleted before we pick up the
shrink index name from the execution state.
Fixes #70595