Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ILM: Rollup action uses GenerateUniqueIndexNameStep #70626

Merged

Conversation

andreidan
Copy link
Contributor

@andreidan andreidan commented Mar 22, 2021

This refactors the RollupILMAction to use the GenerateUniqueIndexNameStep which
performs a few extra validations and retries if the generated name already exists.

@andreidan andreidan added >refactoring :Data Management/ILM+SLM Index and Snapshot lifecycle management v8.0.0 v7.13.0 labels Mar 22, 2021
@andreidan andreidan requested review from dakrone and talevy March 22, 2021 11:06
@elasticmachine elasticmachine added the Team:Data Management Meta label for data/management team label Mar 22, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (Team:Core/Features)

Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this is a nice simplification :)

@talevy
Copy link
Contributor

talevy commented Mar 22, 2021

thanks @andreidan!

@andreidan andreidan merged commit c8bb627 into elastic:master Mar 23, 2021
andreidan added a commit to andreidan/elasticsearch that referenced this pull request Mar 23, 2021
ILM: Rollup action uses GenerateUniqueIndexNameStep
(cherry picked from commit c8bb627)
Signed-off-by: Andrei Dan <[email protected]>
andreidan added a commit that referenced this pull request Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Data Management/ILM+SLM Index and Snapshot lifecycle management >refactoring Team:Data Management Meta label for data/management team v7.13.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants