Mappings: Deprecate index_name.
#7057
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -159,6 +157,10 @@ public T add(Mapper.Builder builder) { | |||
|
|
|||
| @Override | |||
| public Y build(BuilderContext context) { | |||
| if (pathType != ContentPath.Type.FULL && context.indexCreatedVersion().onOrAfter(Version.V_1_4_0)) { | |||
There was a problem hiding this comment.
I think that we should do
path == ContentPath.Type.JUST_NAME instead of pathType != ContentPath.Type.FULL
In case in the future we want to add a new option...
|
Left some comments. Hope this helps. |
| @@ -63,4 +73,24 @@ public void testEmptyArrayProperties() throws Exception { | |||
| .endObject().endObject().string(); | |||
| createIndex("test").mapperService().documentMapperParser().parse(mapping); | |||
| } | |||
|
|
|||
| public void testPathJustName() { | |||
|
I left a couple of comments. Maybe we can also add a small integration test that checks if either index_name of path with just_name is used on indices before 1.4.0 and after? |
clintongormley
added
>breaking
:Search Foundations/Mapping
|
Closed by #9570 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #6677