[DOCS] HTTP client stats #70512
Merged
[DOCS] HTTP client stats #70512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danhermann
added
>docs
elasticmachine
added
Team:Docs
|
Pinging @elastic/es-core-features (Team:Core/Features) |
|
Pinging @elastic/es-docs (Team:Docs) |
jrodewig
reviewed
Mar 17, 2021
There was a problem hiding this comment.
Thanks @danhermann. I left a few suggestions and questions.
In some cases, it wasn't clear if a property would be returned if it was unavailable. I also didn't know if a few fields were misnamed/missing. I'll take another look afterward. Thanks again!
| `remote_address`:: | ||
| (string) | ||
| Remote address for the HTTP client. | ||
| `forwarded_for`:: |
There was a problem hiding this comment.
It looks like the last_uri property may be missing:
https://github.com/elastic/elasticsearch/blob/master/server/src/main/java/org/elasticsearch/http/HttpStats.java#L74
Co-authored-by: James Rodewig <[email protected]>
Co-authored-by: James Rodewig <[email protected]>
Co-authored-by: James Rodewig <[email protected]>
Co-authored-by: James Rodewig <[email protected]>
Co-authored-by: James Rodewig <[email protected]>
Co-authored-by: James Rodewig <[email protected]>
jrodewig
approved these changes
Mar 18, 2021
| `id`:: | ||
| (integer) | ||
| Unique ID for the HTTP client. | ||
| `agent`:: |
There was a problem hiding this comment.
Nit: I'd add a newline between each definition for readability. Won't affect the HTML output tho.
danhermann
added a commit
to danhermann/elasticsearch
that referenced
this pull request
Jun 7, 2021
danhermann
added a commit
that referenced
this pull request
Jun 7, 2021
danhermann
added a commit
to danhermann/elasticsearch
that referenced
this pull request
Jul 2, 2021
danhermann
added a commit
that referenced
this pull request
Jul 5, 2021
danhermann
added a commit
to danhermann/elasticsearch
that referenced
this pull request
Aug 9, 2021
danhermann
added a commit
that referenced
this pull request
Aug 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds documentation for the stats added in #64561.
Preview: https://elasticsearch_70512.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/cluster-nodes-stats.html