Enable Setting Master Node Timeout in Watcher Start/Stop Requests #70425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's in the title, we have to be able to set this timeout. Otherwise, it's impossible to deactive/active watcher or a slow master node. In the worst case scenario, Wacher may be at fault for making the master slow and it becomes impossible to deactive it.
elasticmachine
added
the
Team:Data Management
|
Pinging @elastic/es-core-features (Team:Core/Features) |
danhermann
approved these changes
Mar 15, 2021
There was a problem hiding this comment.
LGTM pending successful CI. Thanks for fixing this, @original-brownbear!
|
Thanks Dan! |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Mar 16, 2021
…astic#70425) It's in the title, we have to be able to set this timeout. Otherwise, it's impossible to deactive/active watcher or a slow master node. In the worst case scenario, Wacher may be at fault for making the master slow and it becomes impossible to deactive it.
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Mar 16, 2021
…astic#70425) It's in the title, we have to be able to set this timeout. Otherwise, it's impossible to deactive/active watcher or a slow master node. In the worst case scenario, Wacher may be at fault for making the master slow and it becomes impossible to deactive it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's in the title, we have to be able to set this timeout. Otherwise,
it's impossible to deactivate/activate watcher or a slow master node.
In the worst case scenario, Watcher may be at fault for making the master slow
and it becomes impossible to deactivate it.