Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Add runtime fields to index templates #70172

Merged

Conversation

lockewritesdocs
Copy link
Contributor

@lockewritesdocs lockewritesdocs commented Mar 9, 2021

This PR adds a mention of runtime fields to the index templates page to inform users of how to create runtime fields in Kibana. Additionally, expands the example section and clarifies the admonition for Fleet and Elastic Agent.

Preview link: https://elasticsearch_70172.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/index-templates.html

@lockewritesdocs lockewritesdocs added >docs General docs changes :Search Foundations/Mapping Index mappings, including merging and defining field types v8.0.0 v7.12.0 v7.13.0 labels Mar 9, 2021
@lockewritesdocs lockewritesdocs self-assigned this Mar 9, 2021
@elasticmachine elasticmachine added Team:Docs Meta label for docs team Team:Search Meta label for search team labels Mar 9, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

Copy link
Contributor

@debadair debadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments/suggestions regarding terminology issues that need to be resolved.

docs/reference/indices/index-templates.asciidoc Outdated Show resolved Hide resolved
docs/reference/indices/index-templates.asciidoc Outdated Show resolved Hide resolved
docs/reference/indices/index-templates.asciidoc Outdated Show resolved Hide resolved
docs/reference/indices/index-templates.asciidoc Outdated Show resolved Hide resolved
docs/reference/indices/index-templates.asciidoc Outdated Show resolved Hide resolved
docs/reference/indices/index-templates.asciidoc Outdated Show resolved Hide resolved
docs/reference/indices/index-templates.asciidoc Outdated Show resolved Hide resolved
@lockewritesdocs lockewritesdocs requested a review from jimczi March 10, 2021 13:14
Copy link
Member

@javanna javanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a small comment, LGTM otherwise

@lockewritesdocs lockewritesdocs merged commit ebeb0a9 into elastic:master Mar 15, 2021
@lockewritesdocs lockewritesdocs deleted the docs__update-index-templates branch March 15, 2021 15:50
lockewritesdocs pushed a commit to lockewritesdocs/elasticsearch that referenced this pull request Mar 15, 2021
* [DOCS] Add runtime fields to index templates

* Apply suggestions from code review

Co-authored-by: debadair <[email protected]>

* Deemphasize runtime fields and Kibana.

* Remove duplicate timestamp from component template.

Co-authored-by: debadair <[email protected]>
lockewritesdocs pushed a commit that referenced this pull request Mar 15, 2021
* [DOCS] Add runtime fields to index templates

* Apply suggestions from code review

Co-authored-by: debadair <[email protected]>

* Deemphasize runtime fields and Kibana.

* Remove duplicate timestamp from component template.

Co-authored-by: debadair <[email protected]>

Co-authored-by: debadair <[email protected]>
lockewritesdocs pushed a commit that referenced this pull request Mar 15, 2021
* [DOCS] Add runtime fields to index templates

* Apply suggestions from code review

Co-authored-by: debadair <[email protected]>

* Deemphasize runtime fields and Kibana.

* Remove duplicate timestamp from component template.

Co-authored-by: debadair <[email protected]>

Co-authored-by: debadair <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes :Search Foundations/Mapping Index mappings, including merging and defining field types Team:Docs Meta label for docs team Team:Search Meta label for search team v7.12.0 v7.13.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants