Update Docker image used by minio test fixture to support Arm #69743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-delivery (Team:Delivery) |
pugnascotia
approved these changes
Mar 1, 2021
There was a problem hiding this comment.
LGTM.
Apparently some arch support is available in the tools - see docker/cli#2551
e.g. I tried the following on my x86 laptop:
docker run --platform=linux/arm64 minio/minio:RELEASE.2019-01-23T23-18-58Zand it failed:
docker: Error response from daemon: image with reference minio/minio:RELEASE.2019-01-23T23-18-58Z was found but does not match the specified platform: wanted linux/arm64, actual: linux/amd64.
Nice. I don't see an equivalent for the |
mark-vieira
added a commit
that referenced
this pull request
Mar 1, 2021
(cherry picked from commit 3144354)
mark-vieira
added a commit
that referenced
this pull request
Mar 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The minio Docker image used by our test fixture used an old tag which didn't support the aarch64 architecture. To be able to test on Arm we need to bump this to a tag which provided an aarch64 image.
Would be nice if docker would fail on
pullhere, instead of just pulling down thex86_64image and then failing to execute commands in it.