Ensure running precommit task compiles all project source sets #69728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-delivery (Team:Delivery) |
|
@elasticmachine run elasticsearch-ci/2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When configuring the
precommittask we attach any source set compile tasks as dependencies so that runningprecommitverifies that all code in the repository can at least correctly compile. This was done via simply iterating over theSourceSetContaineras a simple collection, which is susceptible to configuration ordering issues if a subsequently applied plugin registers a new source set, which is often the case for our REST testing plugins. This pull request refactors this logic to use the lazyall()callback approach so that we ensure any source sets added later will also be properly wired up to theprecommittask.Closes #69715