Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test for final pipelines when target index is changed #69457

Merged
merged 2 commits into from
Mar 4, 2021
Merged

Test for final pipelines when target index is changed #69457

merged 2 commits into from
Mar 4, 2021

Conversation

danhermann
Copy link
Contributor

Adds a test that verifies that when the target index is changed by an ingest pipeline, the final pipeline for the new target index, if any, is executed.

@danhermann danhermann added >test Issues or PRs that are addressing/adding tests :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP v8.0.0 v7.13.0 labels Feb 23, 2021
@elasticmachine elasticmachine added the Team:Data Management Meta label for data/management team label Feb 23, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (Team:Core/Features)

probakowski
probakowski approved these changes Mar 4, 2021
View reviewed changes
Copy link
Contributor

@probakowski probakowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Dan! Can we add check at the end that final_pipeline_1 was not executed?

@danhermann
Copy link
Contributor Author

Thanks, @probakowski! Merged over unrelated BWC test failure.

@danhermann danhermann merged commit be917d4 into elastic:master Mar 4, 2021
@danhermann danhermann deleted the final_pipeline_test branch March 4, 2021 16:40
danhermann added a commit to danhermann/elasticsearch that referenced this pull request Apr 28, 2021
@danhermann
Test for final pipelines when target index is changed (elastic#69457)
b87575a
@danhermann danhermann mentioned this pull request Apr 28, 2021
Merged
danhermann added a commit that referenced this pull request Apr 28, 2021
@danhermann
Test for final pipelines when target index is changed (#69457) (#72405)
33a360e
danhermann added a commit to danhermann/elasticsearch that referenced this pull request May 14, 2021
@danhermann
Test for final pipelines when target index is changed (elastic#69457)
634e5d7
@danhermann danhermann mentioned this pull request May 14, 2021
Merged
danhermann added a commit that referenced this pull request May 17, 2021
@danhermann
Test for final pipelines when target index is changed (#69457) (#73123)
49f06a8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@probakowski probakowski probakowski approved these changes

Assignees
No one assigned
Labels
backport pending :Data Management/Ingest Node Execution or management of Ingest Pipelines including GeoIP Team:Data Management Meta label for data/management team >test Issues or PRs that are addressing/adding tests v7.13.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danhermann @elasticmachine @probakowski @jakelandis