[Transform] stop transform regardless of transform nodes #69419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 23, 2021 12:08
….g. if the cluster lacks a transform node)
hendrikmuhs
force-pushed
the
transform-no-transform-node-stop
branch
from
e6628b8 to
2e4d72c
Compare
|
Pinging @elastic/ml-core (Team:ML) |
.../plugin/transform/src/main/java/org/elasticsearch/xpack/transform/action/TransformNodes.java
Outdated
Show resolved
Hide resolved
davidkyle
reviewed
Feb 23, 2021
...ansform/src/main/java/org/elasticsearch/xpack/transform/action/TransformNodeAssignments.java
Outdated
Show resolved
Hide resolved
.../plugin/transform/src/main/java/org/elasticsearch/xpack/transform/action/TransformNodes.java
Outdated
Show resolved
Hide resolved
Co-authored-by: David Kyle <[email protected]>
|
run elasticsearch-ci/bwc |
...ansform/src/main/java/org/elasticsearch/xpack/transform/action/TransformNodeAssignments.java
Outdated
Show resolved
Hide resolved
| }, e -> { | ||
| if (e instanceof ResourceNotFoundException) { | ||
| Tuple<Set<String>, Set<String>> runningTasksAndNodes = findTasksWithoutConfig(state, request.getId()); | ||
| if (runningTasksAndNodes.v1().isEmpty()) { | ||
| listener.onFailure(e); | ||
| // found transforms without a config | ||
| } else if (request.isForce()) { | ||
| // TODO: handle tasks waiting for assignment |
There was a problem hiding this comment.
So, what is there left to do? Aren't waiting tasks handled by cancelTransformTasksWithNoAssignment?
There was a problem hiding this comment.
this is the special case were the transform "lost" the configuration, meaning it could not be found in the transform index. This happens if you e.g. manually delete the document or the whole index.
I still think we should handle it, but I like to postpone it to the follow up, I added the todo there.
...orm/src/main/java/org/elasticsearch/xpack/transform/action/TransportStopTransformAction.java
Outdated
Show resolved
Hide resolved
...orm/src/main/java/org/elasticsearch/xpack/transform/action/TransportStopTransformAction.java
Outdated
Show resolved
Hide resolved
...orm/src/main/java/org/elasticsearch/xpack/transform/action/TransportStopTransformAction.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Przemysław Witek <[email protected]>
hendrikmuhs
pushed a commit
to hendrikmuhs/elasticsearch
that referenced
this pull request
Feb 24, 2021
allow stop transform to stop a transform task if its waiting for assignment(e.g. if the cluster lacks a transform node) fixes elastic#69260
hendrikmuhs
pushed a commit
to hendrikmuhs/elasticsearch
that referenced
this pull request
Feb 24, 2021
allow stop transform to stop a transform task if its waiting for assignment(e.g. if the cluster lacks a transform node) fixes elastic#69260
hendrikmuhs
pushed a commit
that referenced
this pull request
Feb 24, 2021
hendrikmuhs
pushed a commit
that referenced
this pull request
Feb 24, 2021
hendrikmuhs
pushed a commit
that referenced
this pull request
Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow stop transform to stop a transform task if its waiting for assignment(e.g. if
the cluster lacks a transform node)
fixes #69260