Simplify BwC for UUIDs in RepositoryData #69335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need to separately handle BwC for these two fields since they were both introduced in `7.12`.
original-brownbear
added
>non-issue
:Distributed Coordination/Snapshot/Restore
elasticmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
| @@ -404,28 +406,10 @@ public RepositoryData withGenId(long newGeneration) { | |||
| } | |||
|
|
|||
| /** | |||
| * Make a copy of this instance with the given UUID and all other fields unchanged. | |||
| */ | |||
| public RepositoryData withUuid(String uuid) { | |||
There was a problem hiding this comment.
No point exposing this IMO. This can just be set as an implementation detail if a cluster uuid is set for the first time, no need to expose it separately.
|
@elasticmachine update branch |
|
Jenkins run elasticsearch-ci/2 unrelated and known |
DaveCTurner
approved these changes
Feb 22, 2021
|
Thanks David! |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Feb 22, 2021
We don't need to separately handle BwC for these two fields since they were both introduced in `7.12`.
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Feb 22, 2021
We don't need to separately handle BwC for these two fields since they were both introduced in `7.12`.
original-brownbear
added a commit
that referenced
this pull request
Feb 22, 2021
original-brownbear
added a commit
that referenced
this pull request
Feb 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need to separately handle BwC for these two fields since they
were both introduced in
7.12.