-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Add request body parameters to put Logstash pipeline API docs #69151
[DOCS] Add request body parameters to put Logstash pipeline API docs #69151
Conversation
Pinging @elastic/es-docs (Team:Docs) |
Pinging @elastic/es-core-infra (Team:Core/Infra) |
`username`:: | ||
(Required, string) | ||
User who last updated the pipeline. This username is not generated or used by | ||
{es} or {ls}. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This username is not generated or used by {es} or {ls}.
@jaymode Can you confirm this is the case? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I know, this is the case. @kaisecheng do you know of any uses of the username field?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jaymode the username
display in the pipeline table of central pipeline management, so it is used by Logstash
https://github.com/elastic/kibana/blob/master/x-pack/plugins/logstash/public/application/components/pipeline_list/pipelines_table.js#L59
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for confirming @kaisecheng. I removed the related sentence.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
`username`:: | ||
(Required, string) | ||
User who last updated the pipeline. This username is not generated or used by | ||
{es} or {ls}. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I know, this is the case. @kaisecheng do you know of any uses of the username field?
@elasticmachine run elasticsearch-ci/2 @elasticmachine run elasticsearch-ci/bwc |
@elasticmachine update branch |
Fixes #69148
Additional changes:
pipeline
to lowercasePreview
Request body parameters: https://elasticsearch_69151.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/logstash-api-put-pipeline.html#logstash-api-put-pipeline-request-body