Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update versions after backport of max_analyzed_offset #69029

Merged
merged 1 commit into from
Feb 16, 2021
Merged

Update versions after backport of max_analyzed_offset #69029

merged 1 commit into from
Feb 16, 2021

Conversation

matriv
Copy link
Contributor

@matriv matriv commented Feb 16, 2021 •
edited
Loading

Since #69016 is merged, versions for serialisation/deserialisation
and YAML tests are updated.

Follows: #67325

@matriv
Update versions after backport of max_analyzed_offset
092061f 
Since elastic#69016 is merged versions for serialisation/deserialisation
and YAML tests are updated.

Follows: elastic#67325
@matriv matriv added :Search Relevance/Highlighting How a query matched a document v8.0.0 labels Feb 16, 2021
@elasticmachine elasticmachine added the Team:Search Meta label for search team label Feb 16, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

cbuescher
cbuescher approved these changes Feb 16, 2021
View reviewed changes
Copy link
Member

@cbuescher cbuescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jimczi
jimczi approved these changes Feb 16, 2021
View reviewed changes
Copy link
Contributor

@jimczi jimczi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but next time please disable the bwc tests before merging in master/7x.
The transport serialization is broken so all builds will fail until this PR is merged :(.

@matriv
Copy link
Contributor Author

matriv commented Feb 16, 2021

LGTM but next time please disable the bwc tests before merging in master/7x.
The transport serialization is broken so all builds will fail until this PR is merged :(.

Didn't remember to do that :( sorry!

@matriv matriv merged commit 3ba6e4f into elastic:master Feb 16, 2021
@matriv matriv deleted the update-versions-after-backport branch February 16, 2021 12:54
@pugnascotia pugnascotia added the >test Issues or PRs that are addressing/adding tests label Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbuescher cbuescher cbuescher approved these changes

@jimczi jimczi jimczi approved these changes

Assignees
No one assigned
Labels
:Search Relevance/Highlighting How a query matched a document Team:Search Meta label for search team >test Issues or PRs that are addressing/adding tests v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@matriv @elasticmachine @cbuescher @jimczi @jakelandis @pugnascotia