Fixes assertion check in RollupShardIndexer #68878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the assertion in RollupShardIndexer that verifies that temporary files are deleted. Since it is the responsibility of the indexer to instruct the OS to delete files, it may not do so in a timely manner. This results in a potentially flaky assertion. Instead, a new unit test is introduced that will introspect the indexer and assert that it had successfully called for the files to be deleted. Closes elastic#68609.
talevy
added
>test
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
talevy
added a commit
to talevy/elasticsearch
that referenced
this pull request
Feb 16, 2021
This commit removes the assertion in RollupShardIndexer that verifies that temporary files are deleted. Since it is the responsibility of the indexer to instruct the OS to delete files, it may not do so in a timely manner. This results in a potentially flaky assertion. Instead, a new unit test is introduced that will introspect the indexer and assert that it had successfully called for the files to be deleted. Closes elastic#68609.
talevy
added a commit
that referenced
this pull request
Feb 16, 2021
This commit removes the assertion in RollupShardIndexer that verifies that temporary files are deleted. Since it is the responsibility of the indexer to instruct the OS to delete files, it may not do so in a timely manner. This results in a potentially flaky assertion. Instead, a new unit test is introduced that will introspect the indexer and assert that it had successfully called for the files to be deleted. backport of #68878.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the assertion in RollupShardIndexer that verifies that
temporary files are deleted. Since it is the responsibility of the indexer
to instruct the OS to delete files, it may not do so in a timely manner. This
results in a potentially flaky assertion. Instead, a new unit test is introduced
that will introspect the indexer and assert that it had successfully called
for the files to be deleted.
Closes #68609.