SQL: Fix the MINUTE_OF_DAY() function that throws exception when used in comparisons (#68783) #68854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in comparisons (elastic#68783) The `MINUTE_OF_DAY()` extraction function does not have an equivalent expressible using a datetime format pattern. The `MinuteOfDay.dateTimeFormat()` is called during the query translation and throws an exception, but the return value actually does not impact the translated query (binary comparisons with `DateTimeFunction` on one side always turn into a script query). This change fixes the immediate issue raised as part of elastic#67872, add integration tests covering the problem, but leaves the removal of the unnecessary `dateTimeFormat()` function a separate PR.
palesz
added
:Analytics/SQL
|
Pinging @elastic/es-ql (Team:QL) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
MINUTE_OF_DAY()extraction function does not have an equivalentexpressible using a datetime format pattern.
The
MinuteOfDay.dateTimeFormat()is called during the querytranslation and throws an exception, but the return value actually
does not impact the translated query (binary comparisons with
DateTimeFunctionon one side always turn into a script query).This change fixes the immediate issue raised as part of #67872,
add integration tests covering the problem, but leaves the removal
of the unnecessary
dateTimeFormat()function a separate PR.