Set recovery rate for dedicated cold nodes #68480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit sets the recovery rate for dedicated cold nodes. The goal is here is enhance performance of recovery in a dedicated cold tier, where we expect such nodes to be predominantly using searchable snapshots to back the indices located on them. This commit follows a simple approach where we increase the recovery rate as a function of the node size, for nodes that appear to be dedicated cold nodes.
jasontedor
added
>enhancement
:Distributed Indexing/Recovery
elasticmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
jasontedor
commented
Feb 3, 2021
| // if the node is not a data node, this value doesn't matter, use the default | ||
| return defaultMaxBytesPerSec.getStringRep(); | ||
| } | ||
| if ((dataRoles.size() > 1 || dataRoles.get(0).roleName().equals("data_cold") == false) || |
There was a problem hiding this comment.
Note: we should bring the role definitions into the server code base now.
dakrone
approved these changes
Feb 3, 2021
|
@dakrone I pushed docs. |
|
@elasticmachine update branch |
|
@elasticmachine update branch |
jasontedor
added a commit
that referenced
this pull request
Feb 4, 2021
This commit sets the recovery rate for dedicated cold nodes. The goal is here is enhance performance of recovery in a dedicated cold tier, where we expect such nodes to be predominantly using searchable snapshots to back the indices located on them. This commit follows a simple approach where we increase the recovery rate as a function of the node size, for nodes that appear to be dedicated cold nodes.
jasontedor
added a commit
that referenced
this pull request
Feb 4, 2021
This commit sets the recovery rate for dedicated cold nodes. The goal is here is enhance performance of recovery in a dedicated cold tier, where we expect such nodes to be predominantly using searchable snapshots to back the indices located on them. This commit follows a simple approach where we increase the recovery rate as a function of the node size, for nodes that appear to be dedicated cold nodes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit sets the recovery rate for dedicated cold nodes. The goal is here is enhance performance of recovery in a dedicated cold tier, where we expect such nodes to be predominantly using searchable snapshots to back the indices located on them. This commit follows a simple approach where we increase the recovery rate as a function of the node size, for nodes that appear to be dedicated cold nodes.
Closes #68134