Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure ReplicationOperation notify listener once #68256

Merged
merged 1 commit into from
Jan 31, 2021

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Jan 31, 2021

ReplicationOperation can notify the listener twice if the primary shard is demoted after it has completed the primary operation.

Closes #68049

ReplicationOperation can notify the listener twice if the primary shard is demoted after it has completed the primary operation.
@dnhatn dnhatn added >bug :Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. v8.0.0 v7.12.0 v7.11.1 v7.10.3 labels Jan 31, 2021
@elasticmachine elasticmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Jan 31, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@dnhatn dnhatn requested a review from ywelsch January 31, 2021 03:48
Copy link
Member

@original-brownbear original-brownbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnhatn
Copy link
Member Author

dnhatn commented Jan 31, 2021

Thanks Armin.

@dnhatn dnhatn merged commit 30d155c into elastic:master Jan 31, 2021
@dnhatn dnhatn deleted the notify-once branch January 31, 2021 14:24
dnhatn added a commit that referenced this pull request Feb 2, 2021
ReplicationOperation can notify the listener twice if the primary shard 
is demoted after it has completed the primary operation.

Closes #68049
dnhatn added a commit that referenced this pull request Feb 2, 2021
ReplicationOperation can notify the listener twice if the primary shard 
is demoted after it has completed the primary operation.

Closes #68049
dnhatn added a commit that referenced this pull request Feb 3, 2021
ReplicationOperation can notify the listener twice if the primary shard 
is demoted after it has completed the primary operation.

Closes #68049
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Distributed Indexing/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v7.10.3 v7.11.1 v7.12.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] MlDistributedFailureIT testFullClusterRestart with IndexingPressure is adjusted twice
4 participants