Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Update Painless examples to use seat data #68029

Merged

Conversation

lockewritesdocs
Copy link
Contributor

@lockewritesdocs lockewritesdocs commented Jan 26, 2021

Updates the Painless examples that use // NOTCONSOLE or // TEST[skip] to use the seats example data. Each of these examples will now use //TEST[setup:seats] to run against the integrated test that was introduced in #68008.

@lockewritesdocs lockewritesdocs self-assigned this Jan 26, 2021
@matriv matriv added the >docs General docs changes label Jan 27, 2021
@elasticmachine elasticmachine added the Team:Docs Meta label for docs team label Jan 27, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@lockewritesdocs
Copy link
Contributor Author

@elasticmachine update branch

@lockewritesdocs lockewritesdocs added :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache v8.0.0 labels Jan 27, 2021
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Jan 27, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

docs/build.gradle Outdated Show resolved Hide resolved
Copy link
Contributor

@stu-elastic stu-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, one question about actors.

@lockewritesdocs lockewritesdocs merged commit c91a808 into elastic:master Jan 27, 2021
@lockewritesdocs lockewritesdocs deleted the docs__make-painless-test-again branch January 27, 2021 21:42
lockewritesdocs pushed a commit that referenced this pull request Jan 27, 2021
* Adds datetime as a date, which is necessary in setup.

* Updating field context example.

* Fixing sample data, updating context example, and updating runtime example.

* Updating field context and changing runtime field to use seats data.

* Update filter context to use the seats data.

* Updating min-should-match context to use seats data.

* Replacing last mentions of TEST[skip].

* Update usage with watcher response for build error.

* Updating usage API again for watcher.

* Third time's a charm for fixing test cases.

* Adding specific test replacement for watcher logging total.

* Change actors to keyword based on review feedback.

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
lockewritesdocs pushed a commit that referenced this pull request Jan 27, 2021
…) (#68086)

* Adds datetime as a date, which is necessary in setup.

* Updating field context example.

* Fixing sample data, updating context example, and updating runtime example.

* Updating field context and changing runtime field to use seats data.

* Update filter context to use the seats data.

* Updating min-should-match context to use seats data.

* Replacing last mentions of TEST[skip].

* Update usage with watcher response for build error.

* Updating usage API again for watcher.

* Third time's a charm for fixing test cases.

* Adding specific test replacement for watcher logging total.

* Change actors to keyword based on review feedback.

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >docs General docs changes Team:Core/Infra Meta label for core/infra team Team:Docs Meta label for docs team v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants