-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Update Painless examples to use seat data #68029
Merged
lockewritesdocs
merged 14 commits into
elastic:master
from
lockewritesdocs:docs__make-painless-test-again
Jan 27, 2021
Merged
[DOCS] Update Painless examples to use seat data #68029
lockewritesdocs
merged 14 commits into
elastic:master
from
lockewritesdocs:docs__make-painless-test-again
Jan 27, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/es-docs (Team:Docs) |
@elasticmachine update branch |
…esdocs/elasticsearch into docs__make-painless-test-again
lockewritesdocs
added
:Core/Infra/Scripting
Scripting abstractions, Painless, and Mustache
v8.0.0
labels
Jan 27, 2021
Pinging @elastic/es-core-infra (Team:Core/Infra) |
stu-elastic
reviewed
Jan 27, 2021
docs/painless/painless-contexts/painless-watcher-context-variables.asciidoc
Show resolved
Hide resolved
stu-elastic
reviewed
Jan 27, 2021
stu-elastic
approved these changes
Jan 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, one question about actors.
lockewritesdocs
pushed a commit
that referenced
this pull request
Jan 27, 2021
* Adds datetime as a date, which is necessary in setup. * Updating field context example. * Fixing sample data, updating context example, and updating runtime example. * Updating field context and changing runtime field to use seats data. * Update filter context to use the seats data. * Updating min-should-match context to use seats data. * Replacing last mentions of TEST[skip]. * Update usage with watcher response for build error. * Updating usage API again for watcher. * Third time's a charm for fixing test cases. * Adding specific test replacement for watcher logging total. * Change actors to keyword based on review feedback. Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
lockewritesdocs
pushed a commit
that referenced
this pull request
Jan 27, 2021
…) (#68086) * Adds datetime as a date, which is necessary in setup. * Updating field context example. * Fixing sample data, updating context example, and updating runtime example. * Updating field context and changing runtime field to use seats data. * Update filter context to use the seats data. * Updating min-should-match context to use seats data. * Replacing last mentions of TEST[skip]. * Update usage with watcher response for build error. * Updating usage API again for watcher. * Third time's a charm for fixing test cases. * Adding specific test replacement for watcher logging total. * Change actors to keyword based on review feedback. Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Core/Infra/Scripting
Scripting abstractions, Painless, and Mustache
>docs
General docs changes
Team:Core/Infra
Meta label for core/infra team
Team:Docs
Meta label for docs team
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the Painless examples that use
// NOTCONSOLE
or// TEST[skip]
to use theseats
example data. Each of these examples will now use//TEST[setup:seats]
to run against the integrated test that was introduced in #68008.