Removes toString->parse roundtrip for missing value in terms agg #67954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes unnecessary and confusing roundtrip that missing values are undertaking in the terms agg if they are already specified as numbers. It also improves a somewhat confusing error message when the missing value cannot be parsed according to the specified format. Closes elastic#67197
elasticmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
nik9000
reviewed
Jan 26, 2021
| @@ -454,7 +454,7 @@ public double parseDouble(String value, boolean roundUp, LongSupplier now) { | |||
| try { | |||
| n = format.parse(value); | |||
| } catch (ParseException e) { | |||
| throw new RuntimeException(e); | |||
| throw new RuntimeException("Cannot parse the value [" + value + "] using the pattern [" + pattern + "]"); | |||
There was a problem hiding this comment.
Maybe add , e just so we don't lose it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes unnecessary and confusing roundtrip that missing values are undertaking
in the terms agg if they are already specified as numbers. It also improves a
somewhat confusing error message when the missing value cannot be parsed
according to the specified format.
Closes #67197