Introduce repository UUIDs #67899
Merged
Introduce repository UUIDs #67899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today a snapshot repository does not have a well-defined identity. It can be reregistered with a different cluster under a different name, and can even be registered with multiple clusters in readonly mode. This presents problems for cases where we need to refer to a specific snapshot in a globally-unique fashion. Today we rely on the repository being registered under the same name on every cluster, but this is not a safe assumption. This commit adds a UUID that can be used to uniquely identify a repository. The UUID is stored in the top-level index blob, represented by `RepositoryData`, and is also usually copied into the `RepositoryMetadata` that represents the repository in the cluster state. The repository UUID is exposed in the get-repositories API; other more meaningful consumers will be added in due course. Backport of elastic#67829
DaveCTurner
added
:Distributed Coordination/Snapshot/Restore
elasticmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Jan 25, 2021
This commit suppresses any BWC tests related to snapshots in `master` so that elastic#67899 can be merged to `7.x`. It will mostly be reverted after the merge of elastic#67899 is complete. Relates elastic#66431
DaveCTurner
added a commit
that referenced
this pull request
Jan 25, 2021
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Jan 25, 2021
This commit mostly reverts elastic#67934, except for the change to the version constant `REPOSITORY_UUID_IN_REPO_DATA_VERSION`. Completes the backport of elastic#67829 via elastic#67899
DaveCTurner
added a commit
that referenced
this pull request
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today a snapshot repository does not have a well-defined identity. It
can be reregistered with a different cluster under a different name, and
can even be registered with multiple clusters in readonly mode.
This presents problems for cases where we need to refer to a specific
snapshot in a globally-unique fashion. Today we rely on the repository
being registered under the same name on every cluster, but this is not a
safe assumption.
This commit adds a UUID that can be used to uniquely identify a
repository. The UUID is stored in the top-level index blob, represented
by
RepositoryData, and is also usually copied into theRepositoryMetadatathat represents the repository in the clusterstate. The repository UUID is exposed in the get-repositories API; other
more meaningful consumers will be added in due course.
Backport of #67829