Replace NOT operator with explicit false check
#67817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have an in-house rule to compare explicitly against `false` instead of using the logical not operator (`!`). However, this hasn't historically been enforced, meaning that there are many violations in the source at present. We now have a Checkstyle rule that can detect these cases, but before we can turn it on, we need to fix the existing violations. This is being done over a series of PRs, since there are a lot to fix.
pugnascotia
added
>enhancement
:Delivery/Build
|
Pinging @elastic/es-delivery (Team:Delivery) |
pgomulka
approved these changes
Jan 21, 2021
| @@ -128,7 +128,7 @@ public static boolean parseBooleanLenient(String value, boolean defaultValue) { | |||
| if (value == null) { | |||
| return defaultValue; | |||
| } | |||
| return !(value.equals("false") || value.equals("0") || value.equals("off") || value.equals("no")); | |||
| return (value.equals("false") || value.equals("0") || value.equals("off") || value.equals("no")) == false; | |||
There was a problem hiding this comment.
this probably requires a little bit head scratching. Would it be easier to read if it was series of && and each being == false? Also not sure this needs to be addressed here.
There was a problem hiding this comment.
I refactored it to a switch.
|
@elasticmachine run elasticsearch-ci/bwc |
pugnascotia
added a commit
that referenced
this pull request
Jan 27, 2021
We have an in-house rule to compare explicitly against `false` instead of using the logical not operator (`!`). However, this hasn't historically been enforced, meaning that there are many violations in the source at present. We now have a Checkstyle rule that can detect these cases, but before we can turn it on, we need to fix the existing violations. This is being done over a series of PRs, since there are a lot to fix.
|
Backported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have an in-house rule to compare explicitly against
falseinsteadof using the logical not operator (
!). However, this hasn'thistorically been enforced, meaning that there are many violations in
the source at present.
We now have a Checkstyle rule that can detect these cases, but before we
can turn it on, we need to fix the existing violations. This is being
done over a series of PRs, since there are a lot to fix.