Assert getRepositoryData only on master node #67806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A trap for the uninitiated: only the master should be calling `getRepositoryData()`, but today this isn't checked anywhere so there's a risk that we inadvertently introduce some code that gets the repository data on other nodes too. This commit introduces an assertion to catch that. Second attempt at elastic#67780 which was reverted due to test failures.
DaveCTurner
added
>non-issue
:Distributed Coordination/Snapshot/Restore
elasticmachine
added
the
Team:Distributed (Obsolete)
|
Pinging @elastic/es-distributed (Team:Distributed) |
|
Turns out I was overly pessimistic about the impact of this change, it was just that one test after all. |
DaveCTurner
deleted the
2021-01-20-assert-getrepositorydata-on-master-take-2
branch
DaveCTurner
added a commit
that referenced
this pull request
Jan 21, 2021
A trap for the uninitiated: only the master should be calling `getRepositoryData()`, but today this isn't checked anywhere so there's a risk that we inadvertently introduce some code that gets the repository data on other nodes too. This commit introduces an assertion to catch that. Second attempt at #67780 which was reverted due to test failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A trap for the uninitiated: only the master should be calling
getRepositoryData(), but today this isn't checked anywhere so there'sa risk that we inadvertently introduce some code that gets the
repository data on other nodes too. This commit introduces an assertion
to catch that.
Second attempt at #67780 which was reverted due to test failures.