[Transform] Add support for search-time runtime fields. #67643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
przemekwitek
force-pushed
the
transform_search_runtime_fields
branch
4 times, most recently
from
000f69e to
8973f3f
Compare
przemekwitek
force-pushed
the
transform_search_runtime_fields
branch
from
8973f3f to
6bd4e4c
Compare
|
Pinging @elastic/ml-core (:ml/Transform) |
przemekwitek
force-pushed
the
transform_search_runtime_fields
branch
2 times, most recently
from
262474e to
88eb4bc
Compare
hendrikmuhs
approved these changes
Jan 20, 2021
...est-high-level/src/main/java/org/elasticsearch/client/transform/transforms/SourceConfig.java
Show resolved
Hide resolved
...lugin/core/src/main/java/org/elasticsearch/xpack/core/transform/transforms/SourceConfig.java
Outdated
Show resolved
Hide resolved
przemekwitek
force-pushed
the
transform_search_runtime_fields
branch
from
e75f757 to
c5aed39
Compare
przemekwitek
added a commit
to przemekwitek/elasticsearch
that referenced
this pull request
Jan 21, 2021
przemekwitek
added a commit
that referenced
this pull request
Jan 21, 2021
34 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for specifying search-time runtime fields in
SourceConfigso that these fields can be used by thepivotandlatesttransforms.In this PR there is no validation against runtime fields being used as
group_by,unique_keyorsortbut such a validation may be needed if we come to the conclusion that the performance degradation is significant.Relates #65147