Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ironbank build with latest docker context #67504

Merged
merged 4 commits into from
Jan 18, 2021

Conversation

pugnascotia
Copy link
Contributor

The file download.json is replaced by hardening_manifest.yaml, which
includes various pieces of information about the Iron Bank build.

The file `download.json` is replaced by `hardening_manifest.yaml`, which
includes various pieces of information about the Iron Bank build.
@pugnascotia pugnascotia added >enhancement :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts labels Jan 14, 2021
@elasticmachine elasticmachine added the Team:Delivery Meta label for Delivery team label Jan 14, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

value: "93dcc18adc78c65a028a84799ecf8ad40c936fdfc5f2a57b1acda5a8117fa82c"

# List of project maintainers
maintainers:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should/could we use distro lists here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would they be?

@nkammah any thoughts here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any mention in the doc on using distro lists - the different examples I've looked at in other projects uses individuals. If you're ok with it, let's stick to individuals for now.

@pugnascotia
Copy link
Contributor Author

@elasticmachine update branch

Copy link
Contributor

@nkammah nkammah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left minor comments but lgtm.

# Human-readable description of the software packaged in the image
org.opencontainers.image.description: "You know, for search."
# License(s) under which contained software is distributed
org.opencontainers.image.licenses: "${license}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What will the value be for "${license}"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'll "Elastic-License".

value: "93dcc18adc78c65a028a84799ecf8ad40c936fdfc5f2a57b1acda5a8117fa82c"

# List of project maintainers
maintainers:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any mention in the doc on using distro lists - the different examples I've looked at in other projects uses individuals. If you're ok with it, let's stick to individuals for now.

@pugnascotia pugnascotia merged commit ea395d3 into elastic:master Jan 18, 2021
@pugnascotia pugnascotia deleted the ironbank-hardening-manifest branch January 18, 2021 16:14
pugnascotia added a commit that referenced this pull request Jan 19, 2021
The file `download.json` is replaced by `hardening_manifest.yaml`, which
includes various pieces of information about the Iron Bank build.
@pugnascotia
Copy link
Contributor Author

Backported to 7.x in 867754e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts >enhancement Team:Delivery Meta label for Delivery team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants