-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ironbank build with latest docker context #67504
Update ironbank build with latest docker context #67504
Conversation
The file `download.json` is replaced by `hardening_manifest.yaml`, which includes various pieces of information about the Iron Bank build.
Pinging @elastic/es-delivery (Team:Delivery) |
value: "93dcc18adc78c65a028a84799ecf8ad40c936fdfc5f2a57b1acda5a8117fa82c" | ||
|
||
# List of project maintainers | ||
maintainers: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should/could we use distro lists here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would they be?
@nkammah any thoughts here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any mention in the doc on using distro lists - the different examples I've looked at in other projects uses individuals. If you're ok with it, let's stick to individuals for now.
@elasticmachine update branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left minor comments but lgtm.
# Human-readable description of the software packaged in the image | ||
org.opencontainers.image.description: "You know, for search." | ||
# License(s) under which contained software is distributed | ||
org.opencontainers.image.licenses: "${license}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What will the value be for "${license}"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'll "Elastic-License".
value: "93dcc18adc78c65a028a84799ecf8ad40c936fdfc5f2a57b1acda5a8117fa82c" | ||
|
||
# List of project maintainers | ||
maintainers: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any mention in the doc on using distro lists - the different examples I've looked at in other projects uses individuals. If you're ok with it, let's stick to individuals for now.
The file `download.json` is replaced by `hardening_manifest.yaml`, which includes various pieces of information about the Iron Bank build.
Backported to |
The file
download.json
is replaced byhardening_manifest.yaml
, whichincludes various pieces of information about the Iron Bank build.