Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove assertion that makes many test failing #67265

Merged
merged 1 commit into from
Jan 11, 2021

Conversation

tlrx
Copy link
Member

@tlrx tlrx commented Jan 11, 2021

This pull request removes an assertion that makes many tests to fail on CI until #67160 is merged, which has been opened to fix the underlying issues around that assertion tripping (and brings back the assertion).

The goal here is to limit test triage workload.

@elasticmachine elasticmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Jan 11, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

Copy link
Member

@original-brownbear original-brownbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! happy to see this go away for now :) thanks

@tlrx tlrx merged commit 22ccc86 into elastic:master Jan 11, 2021
@tlrx
Copy link
Member Author

tlrx commented Jan 11, 2021

Thanks Armin. I should have started by this.

@tlrx tlrx deleted the remove-assertion branch January 11, 2021 17:50
tlrx added a commit to tlrx/elasticsearch that referenced this pull request Jan 11, 2021
This commit removes an assertion that makes many tests to fail 
on CI until elastic#67160 is merged, which has been opened to fix the 
underlying issues around that assertion tripping (and brings 
back the assertion).

Relates elastic#67160
tlrx added a commit to tlrx/elasticsearch that referenced this pull request Jan 11, 2021
This commit removes an assertion that makes many tests to fail 
on CI until elastic#67160 is merged, which has been opened to fix the 
underlying issues around that assertion tripping (and brings 
back the assertion).

Relates elastic#67160
tlrx added a commit that referenced this pull request Jan 11, 2021
This commit removes an assertion that makes many tests to fail 
on CI until #67160 is merged, which has been opened to fix the 
underlying issues around that assertion tripping (and brings 
back the assertion).

Relates #67160
tlrx added a commit that referenced this pull request Jan 11, 2021
This commit removes an assertion that makes many tests to fail 
on CI until #67160 is merged, which has been opened to fix the 
underlying issues around that assertion tripping (and brings 
back the assertion).

Relates #67160
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Coordination/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >non-issue Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v7.11.1 v7.12.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants