Don't use hppc ObjectObjectMap in ParseContext.Document #67250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romseygeek
added
:Search Foundations/Mapping
|
Pinging @elastic/es-search (Team:Search) |
javanna
approved these changes
Jan 11, 2021
|
|
||
| import com.carrotsearch.hppc.ObjectObjectHashMap; | ||
| import com.carrotsearch.hppc.ObjectObjectMap; | ||
|
|
There was a problem hiding this comment.
haha you seem to have similar problems as me now?
romseygeek
added a commit
that referenced
this pull request
Jan 11, 2021
HashMap works perfectly well here, no need to rely on a third-party implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this when reviewing #67157, there is no need to use the
HPPC collection here.