[Backport] Build complex automatons more efficiently #66901
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change substantially reduces the CPU and Heap usage of
StringMatcher when processing large complex patterns.
The improvement is achieved by switching the order in which we
perform concatenation and union for common styles of wildcard patterns.
Given a set of wildcard strings:
"*-logs-*"
"*-metrics-*"
"web-*-prod-*"
"web-*-staging-*"
The old implementation would perform steps roughly like:
The outer minimize would require determinizing the automaton, which
was highly inefficient
The new implementation is:
By performing a union of the inner strings before concatenating the
MATCH_ANY ("*") the time & heap space spent on determinizing the
automaton is greatly reduced.
Backport of: #66724