Use a mapping snapshot for fetching nested docs #66877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses the mapping snapshot that we built for the search phase in elastic#66295 for fetching nested documents. This is simpler to reason about because the mapping snapshot is immutable.
nik9000
added
:Search/Search
|
Pinging @elastic/es-search (Team:Search) |
28 tasks
jtibshirani
reviewed
Jan 4, 2021
There was a problem hiding this comment.
This looks like a nice refactor, it continues to consolidate mapping lookup logic onto MappingLookup, in line with the overall design.
This refactor made me notice that we aren't guaranteed to use the same MappingLookup for the query and fetch phases. I wrote a comment here, it'd be great to get your thoughts: #66295 (comment).
jtibshirani
approved these changes
Jan 7, 2021
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Jan 13, 2021
…66877) This uses the mapping snapshot that we built for the search phase in elastic#66295 for fetching nested documents. This is simpler to reason about because the mapping snapshot is immutable.
nik9000
added a commit
that referenced
this pull request
Jan 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the mapping snapshot that we built for the search phase
in #66295 for fetching nested documents. This is simpler to reason about
because the mapping snapshot is immutable.