Use single backslash for nested paths in YAML integration tests #66794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethmlarson
changed the title
jtibshirani
approved these changes
Dec 23, 2020
There was a problem hiding this comment.
Thanks @sethmlarson for fixing this! Good to know when writing future tests.
jtibshirani
added
>test
|
Looking at the labels: maybe we should backport to 7.10 too since we're actively testing that branch. |
|
@jtharpla Definitely, thanks for the review! |
sethmlarson
added a commit
to sethmlarson/elasticsearch
that referenced
this pull request
Dec 23, 2020
sethmlarson
added a commit
to sethmlarson/elasticsearch
that referenced
this pull request
Dec 23, 2020
This was referenced Dec 23, 2020
sethmlarson
added a commit
to sethmlarson/elasticsearch
that referenced
this pull request
Dec 23, 2020
sethmlarson
added a commit
that referenced
this pull request
Dec 23, 2020
sethmlarson
added a commit
that referenced
this pull request
Dec 23, 2020
sethmlarson
added a commit
that referenced
this pull request
Dec 23, 2020
Mpdreamz
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Dec 28, 2020
Already fixed upstream but needs to find its way to the docker images. Relates: elastic/elasticsearch#66794
Mpdreamz
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Dec 28, 2020
Already fixed upstream but needs to find its way to the docker images. Relates: elastic/elasticsearch#66794
github-actions bot
pushed a commit
to elastic/elasticsearch-net
that referenced
this pull request
Dec 28, 2020
Already fixed upstream but needs to find its way to the docker images. Relates: elastic/elasticsearch#66794
github-actions bot
pushed a commit
to elastic/elasticsearch-net
that referenced
this pull request
Dec 28, 2020
Already fixed upstream but needs to find its way to the docker images. Relates: elastic/elasticsearch#66794
Mpdreamz
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Dec 28, 2020
… to land (#5218) Already fixed upstream but needs to find its way to the docker images. Relates: elastic/elasticsearch#66794 Co-authored-by: Martijn Laarman <[email protected]>
Mpdreamz
added a commit
to elastic/elasticsearch-net
that referenced
this pull request
Dec 28, 2020
… to land (#5217) Already fixed upstream but needs to find its way to the docker images. Relates: elastic/elasticsearch#66794 Co-authored-by: Martijn Laarman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This integration test is causing failures in a few clients repositories due to the double backslash. It seems like a single backslash is what is used elsewhere. The change was introduced in #65641.
cc @elastic/clients-team