[Transform] report last search time in transform stats #66718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hendrikmuhs
added
:ml/Transform
hendrikmuhs
force-pushed
the
transform-add-last-search
branch
from
b90e697 to
a3da036
Compare
|
Pinging @elastic/ml-core (:ml/Transform) |
1 task
hendrikmuhs
force-pushed
the
transform-add-last-search
branch
from
a3da036 to
b1bd39a
Compare
| @@ -355,6 +357,8 @@ protected void onStart(long now, ActionListener<Boolean> listener) { | |||
| })); | |||
| } else { | |||
| hasSourceChanged = true; | |||
| context.setChangesLastSearchedAt(instantOfTrigger); | |||
| context.setChangesLastDetectedAt(instantOfTrigger); | |||
There was a problem hiding this comment.
This changes behaviour for changed_last_detected_at. The change seems correct but is it fixing another issue with that not getting updated properly?
There was a problem hiding this comment.
yes, the if is "continuous" mode, the else is "batch". I see no reason why we report changed_last_detected_at (and changed_last_searched_at) only for continuous but not for batch. This makes it more consistent.
hendrikmuhs
force-pushed
the
transform-add-last-search
branch
from
b1bd39a to
7d9510f
Compare
hendrikmuhs
changed the title
hendrikmuhs
changed the title
hendrikmuhs
force-pushed
the
transform-add-last-search
branch
from
7d9510f to
db46fe0
Compare
.../src/main/java/org/elasticsearch/client/transform/transforms/TransformCheckpointingInfo.java
Show resolved
Hide resolved
przemekwitek
approved these changes
Jan 20, 2021
...est/java/org/elasticsearch/xpack/transform/integration/continuous/TransformContinuousIT.java
Show resolved
Hide resolved
hendrikmuhs
force-pushed
the
transform-add-last-search
branch
from
b456f23 to
17854c8
Compare
hendrikmuhs
changed the title
hendrikmuhs
pushed a commit
that referenced
this pull request
Jan 21, 2021
adjusts the version after the backport of #66718 and re-enables BWC
This was referenced Jan 25, 2021
34 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
transforms reports the the last time changes where detected with
changes_last_detected_at, however that doesn't tell a user it searched for changes, this PR adds a fieldlast_search_timeto report when transform searched for changes the last time.fixes #66410
relates #66367
Notes
last_search_time([Transform] refactor cat transform to show more useful information #66367)Review
the main changes are part of
bd59629(#66718), the rest are style and test fixes