Mute JDBC client tests with SSL in FIPS mode #66566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JDBC client can only be configured for SSL with keystores, but we can't use JKS/PKCS12 keystores in FIPS 140-2 mode. Resolves: elastic#66095
jkakavas
added
:Delivery/Build
|
Pinging @elastic/es-delivery (Team:Delivery) |
mark-vieira
requested changes
Dec 17, 2020
| // JDBC client can only be configured for SSL with keystores, but we can't use JKS/PKCS12 keystores in FIPS 140-2 mode. | ||
| if (BuildParams.inFipsJvm) { | ||
| project.tasks.configureEach { | ||
| enabled = true |
There was a problem hiding this comment.
I'm confused, shouldn't this be false? Also, we don't want to diasble all tasks, just Test tasks. Let's do this:
tasks.withType(Test).configureEach {
onlyIf { BuildParams.inFipsJvm == false}
}
There was a problem hiding this comment.
I'm confused, shouldn't this be false?
Copy paste error. Will address your suggestion and merge
jkakavas
added a commit
to jkakavas/elasticsearch
that referenced
this pull request
Dec 22, 2020
JDBC client can only be configured for SSL with keystores, but we can't use JKS/PKCS12 keystores in FIPS 140-2 mode. Resolves: elastic#66095
jkakavas
added a commit
to jkakavas/elasticsearch
that referenced
this pull request
Dec 22, 2020
JDBC client can only be configured for SSL with keystores, but we can't use JKS/PKCS12 keystores in FIPS 140-2 mode. Resolves: elastic#66095
jkakavas
added a commit
to jkakavas/elasticsearch
that referenced
this pull request
Dec 22, 2020
JDBC client can only be configured for SSL with keystores, but we can't use JKS/PKCS12 keystores in FIPS 140-2 mode. Resolves: elastic#66095
jkakavas
added a commit
that referenced
this pull request
Dec 22, 2020
jkakavas
added a commit
that referenced
this pull request
Dec 22, 2020
jkakavas
added a commit
that referenced
this pull request
Dec 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JDBC client can only be configured for SSL with keystores,
but we can't use JKS/PKCS12 keystores in FIPS 140-2 mode.
Resolves: #66095