Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New terms_enum API for discovering terms in the index. #66452

Merged
merged 31 commits into from
May 6, 2021
Merged

New terms_enum API for discovering terms in the index. #66452

merged 31 commits into from
May 6, 2021

Commits on May 6, 2021

  1. A TermsEnum API for discovering terms in the index. 

    Terms matching a given prefix can be returned in alphabetical or by popularity,
A timeout can limit the amount of time spent looking for matches.

Expected to be useful in auto-complete or regex debugging use cases.
    @markharwood
    markharwood committed May 6, 2021
    Configuration menu
    Copy the full SHA
    9ffbb03 View commit details
    Browse the repository at this point in the history

  2. Added HLRC support and related integration test

    @markharwood
    markharwood committed May 6, 2021
    Configuration menu
    Copy the full SHA
    b95cf81 View commit details
    Browse the repository at this point in the history

  3. Added client classes for HLRC. 

    Added yaml test with index filter
    @markharwood
    markharwood committed May 6, 2021
    Configuration menu
    Copy the full SHA
    ab826b4 View commit details
    Browse the repository at this point in the history

  4. License fix

    @markharwood
    markharwood committed May 6, 2021
    Configuration menu
    Copy the full SHA
    7a5e654 View commit details
    Browse the repository at this point in the history

  5. Remove HLRC code for now - requires less-than-ideal package names whi… 

    …le we’re unable to move main server implementation out of xpack (due to security dependency).

Don’t want clients to build dependencies on the wrong package names and the Java client changes are underway anyway.
    @markharwood
    markharwood committed May 6, 2021
    Configuration menu
    Copy the full SHA
    93dfe30 View commit details
    Browse the repository at this point in the history

  6. Return empty arrays when no results rather than no terms property a… 

    …t all
    @markharwood
    markharwood committed May 6, 2021
    Configuration menu
    Copy the full SHA
    58bbf41 View commit details
    Browse the repository at this point in the history

  7. Fix bundling of shardIds for nodes, add success/fail accounting of nu… 

    …mbers of shards
    @markharwood
    markharwood committed May 6, 2021
    Configuration menu
    Copy the full SHA
    7fb781d View commit details
    Browse the repository at this point in the history

  8. Type fixes

    @markharwood
    markharwood committed May 6, 2021
    Configuration menu
    Copy the full SHA
    4e9da39 View commit details
    Browse the repository at this point in the history

  9. Types warning

    @markharwood
    markharwood committed May 6, 2021
    Configuration menu
    Copy the full SHA
    cac1bb3 View commit details
    Browse the repository at this point in the history

  10. Removed hot/warm tier tests (in anticipation of new queryable _tier f… 

    …ield)

Move canMatch logic to run on network thread
Injected searchService so we can use its canMatch method
    @markharwood
    markharwood committed May 6, 2021
    Configuration menu
    Copy the full SHA
    810d638 View commit details
    Browse the repository at this point in the history

  11. Move rest-api-spec and related YML test to new standard home for this… 

    … stuff.
    @markharwood
    markharwood committed May 6, 2021
    Configuration menu
    Copy the full SHA
    156302f View commit details
    Browse the repository at this point in the history

  12. Unused import

    @markharwood
    markharwood committed May 6, 2021
    Configuration menu
    Copy the full SHA
    62af758 View commit details
    Browse the repository at this point in the history

  13. Move test to xpack

    @markharwood
    markharwood committed May 6, 2021
    Configuration menu
    Copy the full SHA
    03f79de View commit details
    Browse the repository at this point in the history

  14. Return early on network thread if can’t match any shards. 

    Remove FLS logic now we use the right searcher.
    @markharwood
    markharwood committed May 6, 2021
    Configuration menu
    Copy the full SHA
    53e12cd View commit details
    Browse the repository at this point in the history

  15. Removed sort by popularity option

    @markharwood
    markharwood committed May 6, 2021
    Configuration menu
    Copy the full SHA
    b36f477 View commit details
    Browse the repository at this point in the history

  16. Unused import

    @markharwood
    markharwood committed May 6, 2021
    Configuration menu
    Copy the full SHA
    3b1b6d9 View commit details
    Browse the repository at this point in the history

  17. Addressing some review comments (thanks Jim/Adrien!)

    @markharwood
    markharwood committed May 6, 2021
    Configuration menu
    Copy the full SHA
    5250cc7 View commit details
    Browse the repository at this point in the history

  18. Docs tidy up

    @markharwood
    markharwood committed May 6, 2021
    Configuration menu
    Copy the full SHA
    3288641 View commit details
    Browse the repository at this point in the history

  19. Provide full stack traces for errors, change TODO comment

    @markharwood
    markharwood committed May 6, 2021
    Configuration menu
    Copy the full SHA
    2c00968 View commit details
    Browse the repository at this point in the history

  20. Move location of YAML test - was causing errors when seated alongside… 

    … core/src/yamlRestTest
    @markharwood
    markharwood committed May 6, 2021
    Configuration menu
    Copy the full SHA
    6a68b70 View commit details
    Browse the repository at this point in the history

  21. Security enhancement - allow access where DLS rewrites to match_all. … 

    …Added security tests
    @markharwood
    markharwood committed May 6, 2021
    Configuration menu
    Copy the full SHA
    1fe0a11 View commit details
    Browse the repository at this point in the history

  22. Remove acquisition of searcher from security check code

    @markharwood
    markharwood committed May 6, 2021
    Configuration menu
    Copy the full SHA
    2f59860 View commit details
    Browse the repository at this point in the history

  23. Changed termenum to termsenum. REST endpoint is now _terms_enum

    @markharwood
    markharwood committed May 6, 2021
    Configuration menu
    Copy the full SHA
    4c38b78 View commit details
    Browse the repository at this point in the history

  24. Checkstyle fix

    @markharwood
    markharwood committed May 6, 2021
    Configuration menu
    Copy the full SHA
    c40a0db View commit details
    Browse the repository at this point in the history

  25. Addressing review comments - formatting, thread pool choices and more

    @markharwood
    markharwood committed May 6, 2021
    Configuration menu
    Copy the full SHA
    6b9f41c View commit details
    Browse the repository at this point in the history

  26. Oops. Thought I’d resolved this review comment but hadn’t

    @markharwood
    markharwood committed May 6, 2021
    Configuration menu
    Copy the full SHA
    814e45e View commit details
    Browse the repository at this point in the history

  27. Changed timeout setting to a TimeValue

    @markharwood
    markharwood committed May 6, 2021
    Configuration menu
    Copy the full SHA
    9897518 View commit details
    Browse the repository at this point in the history

  28. Checkstyle fix

    @markharwood
    markharwood committed May 6, 2021
    Configuration menu
    Copy the full SHA
    2cb91df View commit details
    Browse the repository at this point in the history

  29. In flattened fields make only the value (not the field name) subject … 

    …to case insensitive search
    @markharwood
    markharwood committed May 6, 2021
    Configuration menu
    Copy the full SHA
    6d55f99 View commit details
    Browse the repository at this point in the history

  30. Moved initialisation of data node timing of request from NodeTermsEnu… 

    …mRequest constructor to TransportTermsEnumAction#asyncNodeOperation
    @markharwood
    markharwood committed May 6, 2021
    Configuration menu
    Copy the full SHA
    cf70053 View commit details
    Browse the repository at this point in the history

  31. Remove outdated TODOs

    @markharwood
    markharwood committed May 6, 2021
    Configuration menu
    Copy the full SHA
    22312cf View commit details
    Browse the repository at this point in the history