Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Mute TransformContinuousIT.testContinousEvents #66438

Merged
merged 2 commits into from
Dec 16, 2020

Conversation

jimczi
Copy link
Contributor

@jimczi jimczi commented Dec 16, 2020

Relates #66410

@jimczi jimczi added v8.0.0 >test-mute Use for PR that only mute tests :ml/Transform Transform v7.12.0 labels Dec 16, 2020
@jimczi jimczi requested a review from przemekwitek December 16, 2020 10:54
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (:ml/Transform)

@hendrikmuhs
Copy link

did you check whether its a specific test that causes the failure?

This mute covers a whole test suite, if the problem occurs for a specific case, its better to mute only that one.

You can mute individual cases by adding the AwaitsFix annotation to one of these classes:
TermsGroupByIT, TermsOnDateGroupByIT, DateHistogramGroupByIT, DateHistogramGroupByOtherTimeFieldIT, HistogramGroupByIT, LatestContinuousIT.

@jimczi
Copy link
Contributor Author

jimczi commented Dec 16, 2020

This mute covers a whole test suite, if the problem occurs for a specific case, its better to mute only that one.

I don't think it's the case, see #66410

I pushed ffcb405 to use awaits fix, thanks for the review @hendrikmuhs

@jimczi jimczi merged commit cb486a1 into elastic:master Dec 16, 2020
@jimczi jimczi deleted the test_mute_transform branch December 16, 2020 11:42
jimczi added a commit that referenced this pull request Dec 16, 2020
@jimczi jimczi added v7.11.0 and removed v7.12.0 labels Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:ml/Transform Transform >test-mute Use for PR that only mute tests v7.11.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants