Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add command for manually generating Checkstyle config #66421

Merged
merged 1 commit into from
Dec 16, 2020
Merged

Add command for manually generating Checkstyle config #66421

merged 1 commit into from
Dec 16, 2020

Conversation

danhermann
Copy link
Contributor

No description provided.

@danhermann danhermann added >non-issue :Delivery/Build Build or test infrastructure v8.0.0 labels Dec 15, 2020
@elasticmachine elasticmachine added the Team:Delivery Meta label for Delivery team label Dec 15, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

pugnascotia
pugnascotia approved these changes Dec 16, 2020
View reviewed changes
Copy link
Contributor

@pugnascotia pugnascotia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I had meant to include that 😅

I'm also going to follow up with a PR to move the location of the generated file, since build/ isn't a great place, it turns out.

@pugnascotia pugnascotia changed the title Add command for manually generate Checkstyle config Add command for manually generating Checkstyle config Dec 16, 2020
@pugnascotia pugnascotia merged commit 03e4316 into elastic:master Dec 16, 2020
@danhermann danhermann deleted the update_checkstyle_docs branch December 16, 2020 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pugnascotia pugnascotia pugnascotia approved these changes

Assignees
No one assigned
Labels
:Delivery/Build Build or test infrastructure >non-issue Team:Delivery Meta label for Delivery team v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danhermann @elasticmachine @pugnascotia @jakelandis